Do not require explicit override for plugin-generated methods#17370
Closed
sterliakov wants to merge 1 commit into
Closed
Do not require explicit override for plugin-generated methods#17370sterliakov wants to merge 1 commit into
sterliakov wants to merge 1 commit into
Conversation
Collaborator
Author
|
I hope that |
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
It's transitive |
Collaborator
Author
|
Cross-ref: tox-dev/filelock#337 |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17224.
Ensure that
explicit-overrideerror is never applied to functions which are not present in source code (generated by plugin), because there is no place to applyoverride.