Skip to content

fix(ci): point rainix-sol-artifacts at RPC_URL_ETHEREUM_FORK (fixes main red, #283)#284

Open
thedavidmeister wants to merge 1 commit into
mainfrom
fix-artifacts-rpc-secret
Open

fix(ci): point rainix-sol-artifacts at RPC_URL_ETHEREUM_FORK (fixes main red, #283)#284
thedavidmeister wants to merge 1 commit into
mainfrom
fix-artifacts-rpc-secret

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fixes the rainix-sol-artifacts failure red on main — diagnosed in #283.

Root cause

test.yml fed ETH_RPC_URL from CI_DEPLOY_SEPOLIA_RPC_URL, a legacy org secret that was removed when the org's RPC secrets were consolidated to the canonical RPC_URL_*_FORK scheme. With the secret empty, forge script --rpc-url "" treats the empty URL as a local path and "connection refused"s against the job cwd (test/fixture/) — the misleading error in #283. test.yml is byte-identical since the last green run; only the secret's value flipped to empty.

Fix

The rainix-sol-artifacts task only simulates script/Deploy.sol (forge script … --rpc-url "$ETH_RPC_URL", no --broadcast in CI), so it just needs a working eth fork RPC — not sepolia specifically. Repoint ETH_RPC_URL to the surviving RPC_URL_ETHEREUM_FORK.

One line in test.yml. yamlfmt clean. This is the canonical fork-RPC secret the rest of the org's CI already reads, so no new secret is needed.

Closes #283.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated CI configuration to use the designated Ethereum fork RPC endpoint for automated test runs.

The artifacts job read ETH_RPC_URL from CI_DEPLOY_SEPOLIA_RPC_URL, a legacy org
secret removed in the RPC-secret consolidation to the canonical RPC_URL_*_FORK
scheme. With it empty, forge treated the empty --rpc-url as a local path and
"connection refused" against the cwd (test/fixture/) — main went red with a
misleading error (see #283). The job only SIMULATES script/Deploy.sol, so any
eth fork RPC works; use the surviving RPC_URL_ETHEREUM_FORK.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a4f63c1d-4723-4a1b-9c30-6ad32654cbca

📥 Commits

Reviewing files that changed from the base of the PR and between 8583c77 and 9fda95e.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

📝 Walkthrough

Walkthrough

The CI test workflow changes ETH_RPC_URL to use the Ethereum fork RPC secret and variable fallback instead of the Sepolia deployment RPC configuration.

Changes

Ethereum fork RPC configuration

Layer / File(s) Summary
Update CI RPC source
.github/workflows/test.yml
ETH_RPC_URL now resolves from RPC_URL_ETHEREUM_FORK secret or variable values.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the CI fix and references the affected workflow and issue.
Linked Issues check ✅ Passed The workflow now uses the canonical RPC_URL_ETHEREUM_FORK secret, satisfying #283's need for a valid ETH_RPC_URL.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to swapping the RPC secret in .github/workflows/test.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-artifacts-rpc-secret

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rainix-sol-artifacts CI red since 2026-07-24: ETH_RPC_URL resolves empty (org secret/var, not a code regression)

1 participant