fix(ci): point rainix-sol-artifacts at RPC_URL_ETHEREUM_FORK (fixes main red, #283)#284
Open
thedavidmeister wants to merge 1 commit into
Open
fix(ci): point rainix-sol-artifacts at RPC_URL_ETHEREUM_FORK (fixes main red, #283)#284thedavidmeister wants to merge 1 commit into
thedavidmeister wants to merge 1 commit into
Conversation
The artifacts job read ETH_RPC_URL from CI_DEPLOY_SEPOLIA_RPC_URL, a legacy org secret removed in the RPC-secret consolidation to the canonical RPC_URL_*_FORK scheme. With it empty, forge treated the empty --rpc-url as a local path and "connection refused" against the cwd (test/fixture/) — main went red with a misleading error (see #283). The job only SIMULATES script/Deploy.sol, so any eth fork RPC works; use the surviving RPC_URL_ETHEREUM_FORK. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI test workflow changes ChangesEthereum fork RPC configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
rainix-sol-artifactsfailure red on main — diagnosed in #283.Root cause
test.ymlfedETH_RPC_URLfromCI_DEPLOY_SEPOLIA_RPC_URL, a legacy org secret that was removed when the org's RPC secrets were consolidated to the canonicalRPC_URL_*_FORKscheme. With the secret empty,forge script --rpc-url ""treats the empty URL as a local path and "connection refused"s against the job cwd (test/fixture/) — the misleading error in #283.test.ymlis byte-identical since the last green run; only the secret's value flipped to empty.Fix
The
rainix-sol-artifactstask only simulatesscript/Deploy.sol(forge script … --rpc-url "$ETH_RPC_URL", no--broadcastin CI), so it just needs a working eth fork RPC — not sepolia specifically. RepointETH_RPC_URLto the survivingRPC_URL_ETHEREUM_FORK.One line in
test.yml. yamlfmt clean. This is the canonical fork-RPC secret the rest of the org's CI already reads, so no new secret is needed.Closes #283.
🤖 Generated with Claude Code
Summary by CodeRabbit