Internal: Stabilize timing override registration test in @remotion/transitions - #9754
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — replaces brittle setTimeout(10) sleeps in the timing-override registration test with an event-driven synchronization approach that waits for each sequence and transition to actually register, matching the same pattern already used in the TransitionSeries.Transition and Overlay register at their rendered timeline ranges test.
- Replace
setTimeoutsleeps with registration-completion promises — eachrenderTransitionSeries()call now resets apendingRegistrationStacksset and returns a promise that resolves when all three stacks (first sequence, second sequence, transition) have been observed byonRegisterSequence. - Convert all three call sites to
await renderTransitionSeries(...)— removes the orphanedsetTimeoutlines and relies on the returned promise instead.
DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
@remotion/transitions: Stabilize timing override registration test@remotion/transitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Verification
cd packages/transitions && bun test src/test/transition-series-stack.test.tsx --test-name-pattern "TransitionSeries.Sequence timing overrides cascade to later sequences" --rerun-each 100cd packages/transitions && bun testbun run buildbun run stylecheckRelated to #8375.