Skip to content

Internal: Stabilize timing override registration test in @remotion/transitions - #9754

Merged
samohovets merged 1 commit into
mainfrom
fix/transition-series-timing-overrides-flake
Jul 27, 2026
Merged

Internal: Stabilize timing override registration test in @remotion/transitions#9754
samohovets merged 1 commit into
mainfrom
fix/transition-series-timing-overrides-flake

Conversation

@samohovets

Copy link
Copy Markdown
Member

Summary

  • replace fixed 10ms sleeps in the TransitionSeries timing override test
  • wait for both sequences and the transition to register after each render
  • avoid scheduler-dependent failures on slower CI runners

Verification

  • cd packages/transitions && bun test src/test/transition-series-stack.test.tsx --test-name-pattern "TransitionSeries.Sequence timing overrides cascade to later sequences" --rerun-each 100
  • cd packages/transitions && bun test
  • bun run build
  • bun run stylecheck

Related to #8375.

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Jul 27, 2026 5:13pm
remotion Ready Ready Preview, Comment Jul 27, 2026 5:13pm

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — replaces brittle setTimeout(10) sleeps in the timing-override registration test with an event-driven synchronization approach that waits for each sequence and transition to actually register, matching the same pattern already used in the TransitionSeries.Transition and Overlay register at their rendered timeline ranges test.

  • Replace setTimeout sleeps with registration-completion promises — each renderTransitionSeries() call now resets a pendingRegistrationStacks set and returns a promise that resolves when all three stacks (first sequence, second sequence, transition) have been observed by onRegisterSequence.
  • Convert all three call sites to await renderTransitionSeries(...) — removes the orphaned setTimeout lines and relies on the returned promise instead.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏

@samohovets samohovets changed the title @remotion/transitions: Stabilize timing override registration test Internal: Stabilize timing override registration test in @remotion/transitions Jul 27, 2026
@samohovets
samohovets merged commit c4a07a7 into main Jul 27, 2026
19 checks passed
@samohovets
samohovets deleted the fix/transition-series-timing-overrides-flake branch July 27, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant