Repository navigation
Conversation
| # https://docs.djangoproject.com/en/1.11/ref/settings/#debug | ||
| DEBUG = bool(os.environ.get('DEIS_DEBUG', False)) | ||
|
|
||
| LOG_LEVEL = os.environ.get('LOG_LEVEL', 'DEBUG') |
There was a problem hiding this comment.
Default to DEBUG...? It should default to INFO as running DEBUG in production Django is not the default....
There was a problem hiding this comment.
Ok, I can see that it should be INFO. Will change it.
|
I'm not sure there is any improvement to the current way the log level is configured here...? There are only two modes in django, either DEBUG or INFO. Default should be INFO level. |
|
Yeah, I see your point. Setting |
|
@jfuechsl , so the question is if we want to use I'm not sure If you change it to |
|
We could introduce a |
I like it. That would be the best configurable route to allow for customizing the logs and keep it backwards compatible as a default. Can you also change the commit msg to
|
|
I created #131 which supersedes this one. When can close this. |
|
Closing this in favor of #131 |
This PR introduces an env var
LOG_LEVELwhich sets the logging level of the controller. I will open a PR to add the var to the docs once this is ok'd.