Skip to content

feat(controller/logging): Add flag to enable verbose logging - #131

Merged
Cryptophobia merged 1 commit into
teamhephy:masterfrom
engineyard:feat/conf-log-verbose
Oct 7, 2020
Merged

Cryptophobia merged 1 commit into
teamhephy:masterfrom
engineyard:feat/conf-log-verbose

Conversation

@jfuechsl

Copy link
Copy Markdown
Contributor

This PR supersedes #126.

@Cryptophobia Cryptophobia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Cryptophobia

Copy link
Copy Markdown
Member

Can you add DEIS_DEBUG and LOG_VERBOSE env vars in the documentation of the components here: https://github.com/teamhephy/workflow/blob/master/src/managing-workflow/tuning-component-settings.md#customizing-the-controller

Once that is done, we can merge this in.

@jfuechsl

Copy link
Copy Markdown
Contributor Author

Sure, I'll prepare the PR.

@Cryptophobia

Copy link
Copy Markdown
Member

@jfuechsl , any idea when you can prepare the other PR for the docs repo. I want to get this out with the new release upcoming.

@jfuechsl

jfuechsl commented Oct 1, 2020

Copy link
Copy Markdown
Contributor Author

@Cryptophobia here it is: teamhephy/workflow#128

@Cryptophobia

Copy link
Copy Markdown
Member

@jfuechsl , thank you very much for making the docs PR. I'm going to include it in the next minor release v2.22.1 . There is already a small list of things that are pending and this can be one of them. 👍

@Cryptophobia Cryptophobia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Cryptophobia
Cryptophobia merged commit 9346813 into teamhephy:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants