Google Git
Sign in
chromium / chromium / src / c0f2f73bc76d220a37f98c6eb14f849980821842 / . / net / docs / bug-triage-labels.md
blob: d32cde118264123f36d327ce12cfe4122b1e6516 [file] [log] [blame] [view]
eroman96211952016-02-22 21:42:03[diff] [blame]1# Chrome Network Bug Triage : Components and labels
asankaddd5dc22015-03-20 15:52:40[diff] [blame]2
eroman96211952016-02-22 21:42:03[diff] [blame]3## Some network component caveats
asankaddd5dc22015-03-20 15:52:40[diff] [blame]4
asankad2bdc302016-06-13 20:06:59[diff] [blame]5* **Internals>Network>SSL**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]6
asankad2bdc302016-06-13 20:06:59[diff] [blame]7 This includes issues that should be also tagged as **Security>UX**
8 (certificate error pages or other security interstitials, omnibox indicators
9 that a page is secure), and more general SSL issues. If you see requests
10 that die in the SSL negotiation phase, in particular, this is often the
11 correct component.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]12
asankad2bdc302016-06-13 20:06:59[diff] [blame]13* **Internals>Network>DataProxy**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]14
asankad2bdc302016-06-13 20:06:59[diff] [blame]15 Flywheel / the Data Reduction Proxy. Issues require "Reduce Data Usage" be
davidbenbeccd432016-06-22 18:13:18[diff] [blame]16 turned on. Proxy URL is [https://proxy.googlezip.net:443](#), with
asankad2bdc302016-06-13 20:06:59[diff] [blame]17 [http://compress.googlezip.net:80](#) as a fallback. Currently Android and
18 iOS only.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]19
asankad2bdc302016-06-13 20:06:59[diff] [blame]20* **Internals>Network>Cache**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]21
asankad2bdc302016-06-13 20:06:59[diff] [blame]22 The cache is the layer that handles most range request logic (Though range
23 requests may also be issued by the PDF plugin, XHRs, or other components).
24
25* **Internals>Network>SPDY**
26
27 Covers HTTP2 as well.
28
29* **Internals>Network>HTTP**
30
31 Typically not used. Unclear what it covers, and there's no specific HTTP
32 owner.
33
34* **Internals>Network>Logging**
35
36 Covers **about:net-internals**, **about:net-export** as well as the what's
37 sent to the NetLog.
38
39* **Internals>Network>Connectivity**
40
41 Issues related to switching between networks, `ERR_NETWORK_CHANGED`, Chrome
42 thinking it's online when it's not / navigator.onLine inaccuracies, etc.
43
44* **Internals>Network>Filters**
45
Helen Li923e8d72017-09-20 16:06:08[diff] [blame]46 Covers gzip, deflate and brotli issues. `ERR_CONTENT_DECODING_FAILED`
47 indicates a problem at this layer, and bugs here can also cause response
48 body corruption.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]49
eroman96211952016-02-22 21:42:03[diff] [blame]50## Common non-network components
asankaddd5dc22015-03-20 15:52:40[diff] [blame]51
eroman96211952016-02-22 21:42:03[diff] [blame]52Bugs in these areas often receive the **Internals>Network** component, though
asankaddd5dc22015-03-20 15:52:40[diff] [blame]53they fall largely outside the purview of the network stack team:
54
asankaa30864c2016-12-13 19:28:57[diff] [blame]55* **UI>Browser>Downloads**
56
57 Despite the name, this covers all issues related to downloading a file
58 except saving entire pages (which is **Blink>SavePage**), not just UI
59 issues. Most downloads bugs will have the word "download" or "save as" in
60 the description. Issues with the HTTP server for the Chrome binaries are
61 not downloads bugs.
62
63* **UI>Browser>SafeBrowsing**
64
65 Bugs that have to do with the process by which a URL or file is determined
66 to be dangerous based on our databases, or the resulting interstitials.
67 Determination of danger based purely on content-type or file extension
68 belongs in **UI>Browser>Downloads**, not SafeBrowsing.
69
asankad2bdc302016-06-13 20:06:59[diff] [blame]70* **Blink>Forms**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]71
asankad2bdc302016-06-13 20:06:59[diff] [blame]72 Issues submitting forms, forms having weird data, forms sending the wrong
73 method, etc.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]74
asankad2bdc302016-06-13 20:06:59[diff] [blame]75* **Blink>Loader**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]76
asankad2bdc302016-06-13 20:06:59[diff] [blame]77 Cross origin issues are sometimes loader related. Blink also has an
78 in-memory cache, and when it's used, requests don't appear in
79 about:net-internals. Requests for the same URL are also often merged there
80 as well. This does *not* cover issues with content/browser/loader/ files.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]81
asankad2bdc302016-06-13 20:06:59[diff] [blame]82* **Blink>ServiceWorker**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]83
asankad2bdc302016-06-13 20:06:59[diff] [blame]84* **Blink>Storage>AppCache**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]85
asankad2bdc302016-06-13 20:06:59[diff] [blame]86* **Blink>Network>WebSockets**
tyoshinoc1ece4b2015-12-01 10:52:52[diff] [blame]87
asankad2bdc302016-06-13 20:06:59[diff] [blame]88 Issues with the WebSockets. Attach this component to any issue about the
89 WebSocket feature regardless of where the cause of the issue is (net/ or
90 Blink).
davidben62a1c86a2016-05-05 18:33:51[diff] [blame]91
asankad2bdc302016-06-13 20:06:59[diff] [blame]92* **Blink>Network>FetchAPI**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]93
asankad2bdc302016-06-13 20:06:59[diff] [blame]94 Generic issues with the Fetch API - missing request or response headers,
95 multiple headers, etc. These will often run into issues in certain corner
96 cases (Cross origin / CORS, proxy, whatever). Attach all components that
97 seem appropriate.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]98
asankad2bdc302016-06-13 20:06:59[diff] [blame]99* **Blink>Network>XHR**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]100
asankad2bdc302016-06-13 20:06:59[diff] [blame]101 Generic issues with sync/async XHR requests.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]102
asankad2bdc302016-06-13 20:06:59[diff] [blame]103* **Blink>WebRTC>Network**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]104
asankad2bdc302016-06-13 20:06:59[diff] [blame]105 Anything WebRTC-related does not use the net stack and should go here.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]106
asankad2bdc302016-06-13 20:06:59[diff] [blame]107* **Services>Sync**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]108
asankad2bdc302016-06-13 20:06:59[diff] [blame]109 Sharing data/tabs/history/passwords/etc between machines not working.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]110
asankad2bdc302016-06-13 20:06:59[diff] [blame]111* **Services>Chromoting**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]112
asankad2bdc302016-06-13 20:06:59[diff] [blame]113* **Platform>Extensions**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]114
asankad2bdc302016-06-13 20:06:59[diff] [blame]115 Issues extensions loading / not loading / hanging.
asankaddd5dc22015-03-20 15:52:40[diff] [blame]116
asankad2bdc302016-06-13 20:06:59[diff] [blame]117* **Platform>Extensions>API**
asankaddd5dc22015-03-20 15:52:40[diff] [blame]118
asankad2bdc302016-06-13 20:06:59[diff] [blame]119 Issues with network related extension APIs should have this component.
120 chrome.webRequest is the big one, I believe, but there are others.
121
122* **Internals>Plugins>Pepper[>SDK]**
123
124* **UI>Browser>Omnibox**
125
126 Basically any issue with the omnibox. URLs being treated as search queries
127 rather than navigations, dropdown results being weird, not handling certain
davidbenbeccd432016-06-22 18:13:18[diff] [blame]128 Unicode characters, etc. If the issue is new TLDs not being recognized by
asankad2bdc302016-06-13 20:06:59[diff] [blame]129 the omnibox, that's due to Chrome's TLD list being out of date, and not an
130 omnibox issue. Such TLD issues should be duped against
131 http://crbug.com/37436.
132
133* **Internals>Media>Network**
134
135 Issues related to media. These often run into the 6 requests per hostname
136 issue, and also have fun interactions with the cache, particularly in the
137 range request case.
138
139* **Internals>Plugins>PDF**
140
davidbenbeccd432016-06-22 18:13:18[diff] [blame]141 Issues loading PDF files. These are often related to range requests, which
asankad2bdc302016-06-13 20:06:59[diff] [blame]142 also have some logic at the Internals>Network>Cache layer.
143
144* **UI>Browser>Navigation**
145
146* **UI>Browser>History**
147
148 Issues which only appear with forward/back navigation.
149
150* **OS>Systems>Network** / **OS>Systems>Mobile** / **OS>Systems>Bluetooth**
151
derat817105082017-02-22 17:57:55[diff] [blame]152 These should be used for issues with Chrome OS's platform network code, and
153 not net/ issues on Chrome OS.
asankad2bdc302016-06-13 20:06:59[diff] [blame]154
155* **Blink>SecurityFeature**
156
157 CORS / Cross origin issues. Main frame cross-origin navigation issues are
158 often actually **UI>Browser>Navigation** issues.
159
160* **Privacy**
161
162 Privacy related bug (History, cookies discoverable by an entity that
163 shouldn't be able to do so, incognito state being saved in memory or on disk
164 beyond the lifetime of incognito tabs, etc). Generally used in conjunction
165 with other components.
eroman96211952016-02-22 21:42:03[diff] [blame]166
167## Common labels
asankaddd5dc22015-03-20 15:52:40[diff] [blame]168
asankad2bdc302016-06-13 20:06:59[diff] [blame]169* **Type-Bug-Security**
170
171 Security related bug (Allows for code execution from remote site, allows
172 crossing security boundaries, unchecked array bounds, etc) should be tagged
173 with this label.